On Mon, Sep 19, 2011 at 11:20 PM, Hefty, Sean <[email protected]> wrote: > It would be easier to maintain opensm on windows if it truly shared the same > code base. For now, I'd just like to start with a common ib_types.h file. > (There are currently hundreds, if not thousands, of lines that differ.) > ib_types.h uses #if defined(__WIN__) to separate linux from windows code. > This isn't actually used, since separate files are maintained anyway. > > My question is whether we should continue to use #if defined(__WIN__) or add > a new ib_types_osd.h file. Any preferences from the opensm maintainer side?
Why to test for __WIN__ instead of _WIN32 (defined both when building 32-bit and 64-bit code -- see also http://msdn.microsoft.com/en-us/library/b0084kay%28v=vs.80%29.aspx) ? When creating a common header file, this might be a good start: https://msinttypes.googlecode.com/svn/trunk/stdint.h Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
