Hi Sean, Thank you for your review. In my opinion link_encoding is at the same level as active_speed and active_width, they all help to compute the actual rate.
Marcel On Mon, Sep 19, 2011 at 8:53 PM, Hefty, Sean <[email protected]> wrote: >> Index: b/drivers/infiniband/core/sysfs.c >> =================================================================== >> --- a/drivers/infiniband/core/sysfs.c 2011-09-14 13:49:58.000000000 +0300 >> +++ b/drivers/infiniband/core/sysfs.c 2011-09-14 13:50:43.731775900 +0300 >> @@ -209,7 +209,7 @@ static ssize_t rate_show(struct ib_port >> speed = " DDR"; >> break; >> case 4: >> - speed = " QDR"; >> + speed = attr.link_encoding == 0 ? " QDR" : " FDR10"; >> break; >> } >> >> Index: b/include/rdma/ib_verbs.h >> =================================================================== >> --- a/include/rdma/ib_verbs.h 2011-09-14 13:49:58.000000000 +0300 >> +++ b/include/rdma/ib_verbs.h 2011-09-14 13:50:43.740777700 +0300 >> @@ -319,6 +319,7 @@ struct ib_port_attr { >> u8 active_speed; >> u8 phys_state; >> u8 ext_active_speed; >> + u8 link_encoding; > > This is such a low level detail, that it doesn't make sense to me to expose > it above verbs. > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
