On Thu, Sep 22, 2011 at 8:29 PM, Hefty, Sean <[email protected]> wrote:
> Signed-off-by: Sean Hefty <[email protected]>
> ---
> libibnetdisc/src/ibnetdisc.c | 2 +-
> src/ibportstate.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
> mode change 100644 => 100755 libibnetdisc/src/ibnetdisc.c
> mode change 100644 => 100755 src/ibportstate.c
A minor nit: is this mode change really necessary ? (I know Visual
Studio does enable the execute bit without asking.)
> diff --git a/libibnetdisc/src/ibnetdisc.c b/libibnetdisc/src/ibnetdisc.c
> index 86210eb..c93e7ad
> --- a/libibnetdisc/src/ibnetdisc.c
> +++ b/libibnetdisc/src/ibnetdisc.c
> @@ -201,7 +201,7 @@ static void debug_port(ib_portid_t * portid, ibnd_port_t
> * port)
>
> static int is_mlnx_ext_port_info_supported(ibnd_port_t * port)
> {
> - uint16_t devid = mad_get_field(port->node->info, 0, IB_NODE_DEVID_F);
> + uint16_t devid = (uint16_t) mad_get_field(port->node->info, 0,
> IB_NODE_DEVID_F);
Has it been considered to disable the MSVC warnings about possible
truncation instead of inserting a cast ? MSVC generates such warnings
while gcc does not.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
