On Tue, 27 Sep 2011 15:52:30 -0700 Marcus R Epperson <[email protected]> wrote:
> > Signed-off-by: Marcus R Epperson <[email protected]> I am curious if you have actually hit this bug. I have not run into any non-switches which set AllPortSelect which would lead to this condition.[*] In this case was it your intention to suppress the errors for "all" ports and allow the individual ports to print? I believe this is the correct behaviour. Also, I assume this patch and 2/2 must go together. However, this patch should include the braces from patch 2 to disambiguate the else statement. Could you redo the series for that? Thanks, Ira [*] but apparently the spec does not limit AllPortSelect to switches... > --- > src/ibqueryerrors.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/ibqueryerrors.c b/src/ibqueryerrors.c > index fa116a9..230f6b2 100644 > --- a/src/ibqueryerrors.c > +++ b/src/ibqueryerrors.c > @@ -427,8 +427,9 @@ static int print_results(ib_portid_t * portid, char > *node_name, > } > > if (portnum == 0xFF) > - printf(" GUID 0x%" PRIx64 " port ALL:%s\n", > - node->ports[0]->guid, str); > + if (node->type == IB_NODE_SWITCH) > + printf(" GUID 0x%" PRIx64 " port ALL:%s\n", > + node->ports[0]->guid, str); > else > printf(" GUID 0x%" PRIx64 " port %d:%s\n", > node->ports[portnum]->guid, portnum, str); > -- > 1.7.4.1 > -- Ira Weiny Math Programmer/Computer Scientist Lawrence Livermore National Lab 925-423-8008 [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
