On Fri, Oct 14, 2011 at 3:48 AM, Nicholas A. Bellinger <[email protected]> wrote: > This patch adds the kernel module ib_srpt SCSI RDMA Protocol (SRP) target > implementation conforming to the SRP r16a specification for the mainline > drivers/target infrastructure as requested by Christoph for an initial > v3.2-rc1 merge.
Issues that have been fixed in the SCST source tree but not yet in the LIO source tree: - Handling error completions for failed multipart RDMA transfers causes trouble (fixed in r3632 in the SCST repository). - srpt_map can cause memory corruption (fixed in r3262 in the SCST repository). Issues introduced in the LIO source tree: - Using 128 bits for identifying a port seems overkill to me - 64 bits is sufficient. Also, there is no guarantee that the formula used for computing the port GID (node GUID + port number) will match the port GID. - srpt_make_nodeacl() returns 0 instead of an error code if srpt_alloc_fabric_acl() fails. - The headers of srpt_make_tport() and srpt_drop_tport() should be updated such that these read "$driver/$port" instead of "$driver/$target". Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
