On Mon, 2011-10-24 at 18:34 +0200, Bart Van Assche wrote: > On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger > <n...@linux-iscsi.org> wrote: > > This patch converts the srp_max_rdma_size module parameter into a per > > endpoint configfs attribute. This includes adding the necessary bits > > for show + store attributes w/ min/max bounds checking, and updating > > srpt_get_ioc() to accept a struct srpt_port parameter. > > > > [ ... ] > > > > -static void srpt_get_ioc(struct srpt_device *sdev, u32 slot, > > +static void srpt_get_ioc(struct srpt_port *sport, u32 slot, > > struct ib_dm_mad *mad) > > The SRP spec says that there should be only one value for > iocp->rdma_size per I/O controller. This patch breaks that rule. I'm > not sure it's a good idea to introduce such behavior changes. >
Hi Bart, This is something that Roland asked me to persue, so i'll have to defer to his judgment if he want's to kick this back out to a module parameter or not. --nab -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
