On Thu, 2011-12-01 at 13:55 -0500, Bart Van Assche wrote:
> Make the logging code more a little more brief by replacing
> printk(KERN_WARNING PFX ...) by pr_warn(...) and by replacing
> printk(KERN_ERR PFX ...) by pr_err(...). Remove one trailing
> space to avoid a checkpatch warning.
This is a good step; three minor nits:
1) Please go ahead and merge the multiline strings into one, even though
checkpatch will complain about the line length. I'm not a huge fan of
the long lines either, but Linus has clearly stated his preference for
being able to grep the string in the message
2) Please re-align the variables on wrapped lines to just after the (;
below the work token should be pushed over by one space.
3) All the commit message needs to really say is 'Using pr_* is
preferred over printk.' Probably can just be the short summary, and no
commit body needed.
> if (token != SRP_REV10_IB_IO_CLASS &&
> token != SRP_REV16A_IB_IO_CLASS) {
> - printk(KERN_WARNING PFX "unknown IO class
> parameter value"
> + pr_warn("unknown IO class parameter value"
> " %x specified (use %x or %x).\n",
> token, SRP_REV10_IB_IO_CLASS,
> SRP_REV16A_IB_IO_CLASS);
> goto out;
Thanks!
--
Dave Dillow
National Center for Computational Science
Oak Ridge National Laboratory
(865) 241-6602 office
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
