On Wed, 2011-12-28 at 15:20 -0500, chas williams - CONTRACTOR wrote: > On Wed, 28 Dec 2011 19:46:14 +0000 > Bart Van Assche <[email protected]> wrote: > > > value of sg_tablesize in the SRP login string but ignores that value > > entirely. Was that on purpose ? Shouldn't the statement > > "target->sg_tablesize = indirect_sg_entries ? : cmd_sg_entries" rather > > have been something like "if (!target->sg_tablesize) > > target->sg_tablesize = indirect_sg_entries ? : cmd_sg_entries" ? > > srp_parse_options() happens after target->sg_tablesize is initialized > by this statement.
Right, we set defaults based on module parameters, then let the user override them with the login string. -- Dave Dillow National Center for Computational Science Oak Ridge National Laboratory (865) 241-6602 office -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
