I did explore that option, however,
Bad Version essentially gives message as

“MAD returned with Bad Status: Unsupported Class or Version”

which seems better and appropriate than 
IB_MGMT_MAD_STATUS_UNSUPPORTED_METHOD_ATTRIB

“MAD returned with Bad Status: Unsupported Method/Attribute Combination”.

-----Original Message-----
From: Or Gerlitz [mailto:[email protected]]
Sent: Wednesday, January 18, 2012 3:35 PM
To: Swapna Thete
Cc: [email protected]; [email protected]; Jack Morgenstein
Subject: Re: [PATCH 2/2] IB/mad: Return unsupported for MADs as appropriate

On 1/18/2012 10:43 AM, Swapna Thete wrote:
> @@ -1963,6 +1963,16 @@ local:
> +     } else {
> +             memcpy(response, recv, sizeof(*response));
> +             response->header.recv_wc.wc =&response->header.wc;
> +             response->header.recv_wc.recv_buf.mad =&response->mad.mad;
> +             response->header.recv_wc.recv_buf.grh =&response->grh;
> +             response->mad.mad.mad_hdr.method = IB_MGMT_METHOD_GET_RESP;
> +             response->mad.mad.mad_hdr.status =
> +                             __be16_to_cpu(IB_MGMT_MAD_STATUS_BAD_VERSION);
Don't we want here IB_MGMT_MAD_STATUS_UNSUPPORTED_METHOD_ATTRIB ?

Or.
> +             agent_send_response(&response->mad.mad,&recv->grh, wc,
> +                     port_priv->device, port_num, qp_info->qp->qp_num);
>       }
>
>   out:
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



This message and any attached documents contain information from QLogic 
Corporation or its wholly-owned subsidiaries that may be confidential. If you 
are not the intended recipient, you may not read, copy, distribute, or use this 
information. If you have received this transmission in error, please notify the 
sender immediately by reply e-mail and then delete this message.

Reply via email to