On Sat, 2012-01-14 at 12:57 +0000, Bart Van Assche wrote:
> Add fast_io_fail_tmo and dev_loss_tmo sysfs attributes. Block
> the SCSI target as soon as a transport layer error has been
> detected (ping timeout, disconnect or IB error completion). Try
> to reconnect until dev_loss_tmo elapses.
> 
> Disconnect the IB connection earlier in srp_remove_target() to
> make sure that error recovery is not triggered during host
> removal. Swap the "connected" and "removed" tests in
> srp_queuecommand() because of this change.
> 
> Rescan LUNs after having unblocked a SCSI target controlled by
> ib_srp.

The inclusion of the ping gets 16..18 a NAK from me. As I've previously
said, this is better handled by user space and you add additional
failure cases when you try to retrofit a transport ping into SRP. Just
don't do it.

I'll try to parse through the rest of this soon to give you feedback on
the conversion to dev_loss_tmo etc.

-- 
Dave Dillow
National Center for Computational Science
Oak Ridge National Laboratory
(865) 241-6602 office

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to