On Sat, 2012-01-14 at 12:39 +0000, Bart Van Assche wrote: > Make the logging code a little more brief by replacing > printk(KERN_WARNING PFX ...) by pr_warn(...) and by replacing > printk(KERN_ERR PFX ...) by pr_err(...). Join log messages > split over multiple lines into a single line to make it easier > to grep for these messages. Change the severity of the log > statement in srp_qp_event() from "error" to "debug". Change a > double space into a single in the "bad IO class parameter" error > message. Remove one trailing space to avoid a checkpatch warning.
All you really need for the commit message is "Using pr_* is preferred over printk". The rest is superfluous and readily apparent from the patch itself. Otherwise, this patch is fine. -- Dave Dillow National Center for Computational Science Oak Ridge National Laboratory (865) 241-6602 office -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
