> +/* mailbox cmd response */
> +struct ocrdma_mbx_rsp {
> + u32 subsys_op;
> + u32 status;
> + u32 rsp_len;
> + u32 add_rsp_len;
> +} __packed;
...similar comments about only using __packed where you really need it...
> +#define is_cqe_valid(cq, cqe) \
> + (((le32_to_cpu(cqe->flags_status_srcqpn) & OCRDMA_CQE_VALID)\
> + == cq->phase) ? 1 : 0)
> +#define is_cqe_for_sq(cqe) \
> + ((le32_to_cpu(cqe->flags_status_srcqpn) & OCRDMA_CQE_QTYPE) ? 0 : 1)
> +#define is_cqe_for_rq(cqe) \
> + ((le32_to_cpu(cqe->flags_status_srcqpn) & OCRDMA_CQE_QTYPE) ? 1 : 0)
> +#define is_cqe_invalidated(cqe) \
> + ((le32_to_cpu(cqe->flags_status_srcqpn) & OCRDMA_CQE_INVALIDATE) ? \
> + 1 : 0)
> +#define is_cqe_imm(cqe) \
> + ((le32_to_cpu(cqe->flags_status_srcqpn) & OCRDMA_CQE_IMM) ? 1 : 0)
> +#define is_cqe_wr_imm(cqe) \
> + ((le32_to_cpu(cqe->flags_status_srcqpn) & OCRDMA_CQE_WRITE_IMM) ? 1 :
> 0)
...similar comment about using readable typesafe inline functions
instead of macros...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
