On 4/2/2012 4:25 PM, Hal Rosenstock wrote:

I think there are 3 main issues here:
1. EINVAL can be returned from rate_show and hence "Invalid argument"
rate string should be handled in libibumad. I think this was Bart's original 
point.
2. Why is rate_show returning EINVAL ? I think that's what you're trying
to isolate with the additional printks you sent Bart for sysfs.c.
3. link_layer ethernet should also be handled which is the issue you raised.
Just to sync, I just sent kernel patches which should eliminate the case when EINVAL is seen by rate_show after calling into the mlx4 driver. This addresses point #2, as for #3, I made a check and forced Ethernet link layer on IB port, in this case the mlx4 driver issues the ethernet port query command and it returns valid value for active_speed (4) so I didn't patch that code too. As for libibumad fixes, I'm not dealing with that...

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to