On Mon, Apr 2, 2012 at 8:42 PM, Roland Dreier <[email protected]> wrote:
> On Mon, Apr 2, 2012 at 7:45 AM, Or Gerlitz <[email protected]> wrote:
> > switch (attr.active_speed) {
> > case IB_SPEED_SDR:
> > + speed = " SDR";
> > rate = 25;
> > break;
> > case IB_SPEED_DDR:
>
> I don't think we want this -- old kernels didn't print "SDR" so I think
> we shouldn't change the interface at this point.
Oh, I see what you mean - and I don't think we need to consider this
as interface change - these is an interface - namely "nGbs (mX DDD)
where n is number m is number and DDD is string (SDR, DDR, QDR,
FDR10, etc) and this interface was buggy to wrong print certain cases,
which we fixed in the two commits I mentioned. Now we found another
bug ("SDR" not printed) and we fix it (hopefully the last one in this
function) - that's all. I don't think we should assume there are
apps/libs up their who set their code to match the exact bugs we had
in sysfs, it was just not important enough the report on, or they
didn't hit it (e.g SDR is pretty not common now), thoughts?
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
