I agree that setting it via the network scripts is preferable - if we can find a fairly consistent way to do it across distros.
Ira - one thing: the qlogic patch didn't hardcode the node description, it simply defaulted to using the current hostname. The name could still be overwritten by the user as in stock OFED. -----Original Message----- From: Jason Gunthorpe [mailto:[email protected]] Sent: Wednesday, April 04, 2012 1:12 PM To: Ira Weiny Cc: Heinz, Michael William; [email protected]; Doug Ledford; Bob Ciotti; James Silva Subject: Re: [RFC] Proposal to change Node Description naming scheme for HCA's On Tue, Apr 03, 2012 at 07:14:42PM -0700, Ira Weiny wrote: > On Mon, 2 Apr 2012 12:45:45 -0600 > Jason Gunthorpe <[email protected]> wrote: > > > On Mon, Apr 02, 2012 at 03:27:35PM +0000, Heinz, Michael William wrote: > > > > > Any ideas on how we could solve the hostname problem while we're > > > changing the description? > > > > The node description needs to be set from the DCHP notifier script > > chain (eg /etc/network/if-up.d/ on Debian) and also from a udev rule > > triggered on device insertion. > > Jason, I'm confused. Do you mean DHCP? Yes.. > It seems are you indicating you would like to see if[up/down] bring > ports up/down like they do for IP? No.. > On my ubuntu box (the closest thing I have to Debian) it looks like > ifupdown owns /etc/network/if-up.d and that is not specific to DHCP. > I don't think DHCP should be required for IB. if-up.d/ is a '.d' directory, the idea is individual packages drop their script files in the directory and the system runs them at defined times. No package owns the directory. The purpose of placing a hook here is this call path is used when the hostname changes via DHCP so you can have a chance to reset the node description. > Using udev to set this __seems__ like a better idea although I have > not prototyped it. The purpose of the udev hook path is to set the node description on initial device insertion, which may be before, or after the DHCP process completes, in such cases. It may also be before or after the openibd script.. Having init.d scripts depend on the ordering of hardware discovery and module loading is considered sketchy these days with all the parallel boot fancyness and what not. IMHO we should have a udev rule that also loads the higher level IB modules when any RDMA capable device is discovered, including the mlx4 IB layer, uverbs, umad, etc. This way systems that have RDMA will load the right modules and systems that don't, won't. Fully supporting hot plug, of course. This would broadly eliminate the openibd script, integrate more correctly with the modern distro world, be better prepared for systemd and just be an overall better example for distros to follow :) > > It should probably not be set from the openibd script.. > > I agree there might be better ways but I am not sure I follow your > proposal. Furthermore, I don't know that a start up script of some > sort is all that evil. > > Finally, I think Michael brings up a good point about which package > should own any such scripts. udev is like if-up.d/, there is a rules directory packages can drop hook scripts into that run at the appropriate time. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
