On 04/06/2012 01:12 PM, Hefty, Sean wrote: > ibacm: Fixes to ACM package to support distros > > From: Sean Hefty <sean.he...@intel.com> > > Set of changes to fixup the ibacm package for inclusion into RedHat 6. > Changes are based on feedback from Doug Ledford <dledf...@redhat.com>. > These are primarily changes to the build files, along with name changes > to the man pages and sample configuration files. > > Rename the ib_acm service to match the package name, ibacm. > > Rename the ibacm configuration files to use the prefix 'ibacm' instead > of 'acm'. The new sample files are 'ibacm_addr.cfg' and 'ibacm_opts.cfg'. > > Move location of ACM lock and configuration files and ibacm.pid > files. They are currently in non-standard locations. > > Modify ibacm and ib_acme to use $sysconfdir, $bindir, and rdmadir > configure values. The ibacm_addr.cfg and ibacm_opt.cfg files will now be > read/written to $sysconfdir/$rdmadir by default, with rdmadir defaulting > to 'rdma' if not specified.. And ibacm will execute > $bindir/ib_acme if it needs to create the ibacm_addr.cfg file. Without > $bindir, the ibacm service can fail to launch ib_acme when started > from an init script. > > Add init script as part of install. The init script is installed > into $sysconfdir/init.d. The init script is processed by configure, > so that it executes the correct ibacm service that was installed. > > Fixup man pages based on changes. > > Signed-off-by: Doug Ledford <dledf...@redhat.com> > Signed-off-by: Sean Hefty <sean.he...@intel.com> > --- > Changes from v1: > > Removed mkdir calls from Makefile and replaced them with -D install option. > > Removed setting PATH in init script. Init script is now processed by > configure > to handle the case where the daemon is not installed in /usr/sbin. > Renamed init script to match package / daemon name. > > User can now specify the directory for configuration files by setting > rdmadir=<some_directory> when running configure. By default rdmadir=rdma. > rdmadir is passed to the compiler as a define. > > Fixed other minor issues, like name changes in man pages.
This looks good enough to me Sean. Ack to the version 2 patch set.
--
Doug Ledford <dledf...@redhat.com>
GPG KeyID: 0E572FDD
http://people.redhat.com/dledford
signature.asc
Description: OpenPGP digital signature
