Hi Jim, On 17:55 Mon 25 Jun , Jim Foraker wrote: > A subnet should not be listed as cleanly initialized if CAs > fail to respond to SubnGet requests. > > Signed-off-by: Jim Foraker <[email protected]> > --- > opensm/osm_sm_mad_ctrl.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/opensm/osm_sm_mad_ctrl.c b/opensm/osm_sm_mad_ctrl.c > index f0bcff2..464b6b0 100644 > --- a/opensm/osm_sm_mad_ctrl.c > +++ b/opensm/osm_sm_mad_ctrl.c > @@ -741,6 +741,15 @@ static void sm_mad_ctrl_send_err_cb(IN void *context, IN > osm_madw_t * p_madw) > cl_ntoh16(p_smp->attr_id), > ib_get_sm_attr_str(p_smp->attr_id)); > p_ctrl->p_subn->subnet_initialization_error = TRUE; > + } else if (p_madw->status == IB_TIMEOUT && > + p_smp->method == IB_MAD_METHOD_GET) {
It's pretty common to see timeouts in fabrics without m_key support (e.g. switch reboots) and it's not desirable to start another heavy sweep because of that. So I guess it would be better if we could initiate heavy sweep only when m_key is set and protection level is 2 or 3. > + /* Timeouts on SubnGet may be an indication of an mkey > + error at protection levels 2/3 */ > + OSM_LOG(p_ctrl->p_log, OSM_LOG_ERROR, "ERR 3120 " > + "Timeout while getting attribute 0x%X (%s)\n", > + cl_ntoh16(p_smp->attr_id), > + ib_get_sm_attr_str(p_smp->attr_id)); > + p_ctrl->p_subn->subnet_initialization_error = TRUE; > } > > osm_dump_dr_smp(p_ctrl->p_log, p_smp, OSM_LOG_VERBOSE); > -- > 1.7.9.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
