From: Or Gerlitz <[email protected]>
Date: Thu, 19 Jul 2012 19:15:02 +0300
> -static void neigh_add_path(struct sk_buff *skb, struct neighbour *n, struct
> net_device *dev)
> +static void neigh_add_path(struct sk_buff *skb, u8 *daddr,
> + struct net_device *dev)
Please line up "struct net_device *dev" with the first column after the
openning parenthesis on the first line.
> + return jhash(daddr+12, 8, 0xFFFFFF & *(u32 *) daddr) & htbl->mask;
It would be tons faster to go:
u32 *daddr_32 = (u32 *) daddr;
hv = jhash_3words(daddr_32[3], daddr_32[4], 0xFFFFFF & daddr_32[0], 0);
hv &= htbl->mask;
Plain jhash() has loops and various conditions that are entirely
unnecessary when you know how much you are hashing ahead of time.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
