> -----Original Message----- > From: Roland Dreier [mailto:[email protected]] > Sent: Thursday, August 16, 2012 9:41 AM > To: Pandit, Parav > Cc: [email protected] > Subject: Re: [PATCHv1] RDMA/ocrdma: Fixed CONFIG_VLAN_8021Q. > > On Sat, Aug 11, 2012 at 6:28 AM, Parav Pandit <[email protected]> > wrote: > > +static struct net_device *ocrdma_get_real_netdev(struct net_device > > +*netdev) { #if IS_ENABLED(CONFIG_VLAN_8021Q) > > + return vlan_dev_real_dev(netdev); #else > > + return netdev; > > +#endif > > +} > > As I said before, I don't think this wrapper is needed, and even if it were, > it > would be much better to write it without using the preprocessor (as I said, > you can do "if (IS_ENABLED(...))" in C code now too). > > I'm going to stick to my simpler version unless there is something wrong with > it... [PP] O.k. I am fine with your solution too.
> > - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
