> -----Original Message----- > From: [email protected] [mailto:linux-rdma- > [email protected]] On Behalf Of Or Gerlitz > Sent: Thursday, September 20, 2012 3:31 PM > To: [email protected] > Cc: [email protected]; Or Gerlitz > Subject: [PATCH libmlx4 1/8] Add raw packet QP support > > Implement raw packet QPs for Ethernet ports. > > Signed-off-by: Or Gerlitz <[email protected]> > --- > src/qp.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/src/qp.c b/src/qp.c > index 40a6689..90c4e80 100644 > --- a/src/qp.c > +++ b/src/qp.c > @@ -286,6 +286,10 @@ int mlx4_post_send(struct ibv_qp *ibqp, struct > ibv_send_wr *wr, > size += sizeof (struct mlx4_wqe_datagram_seg) / 16; > break; > > + case IBV_QPT_RAW_PACKET: > + /* For raw eth, the MLX4_WQE_CTRL_SOLICIT flag is > used > + * to indicate that no icrc should be calculated */ > + ctrl->srcrb_flags |= > htonl(MLX4_WQE_CTRL_SOLICIT); > default: > break; > }
Add a break for the new case? While the above code works as expected, it is inconsistent from what it was before, and could lead to problems if the default case starts doing something. Dean -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
