On Fri, Oct 19, 2012 at 2:58 PM, Kleber Sacilotto de Souza <[email protected]> wrote: > void rdma_addr_unregister_client(struct rdma_addr_client *client) > { > put_client(client); > - wait_for_completion(&client->comp); > + wait_for_completion_timeout(&client->comp, 5*HZ); > } > EXPORT_SYMBOL(rdma_addr_unregister_client);
This type of change looks pretty risky to me. Aren't we just letting things continue with a potential use-after-free hanging around? Where does 5 seconds as a timeout come from? Can we be confident that nothing will complete client->comp after 5 seconds? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
