On Fri, 2012-12-14 at 17:12 +0100, Bart Van Assche wrote: > Thanks for the quick reply. You might have missed Vu's message though. > Vu Pham reported that v1 of this patch did not fix the endless error > handling loop (see e.g. > http://www.mail-archive.com/[email protected]/msg13713.html). > > As far as I know invoking srp_send_tsk_mgmt() if the QP is in error is > harmless and won't even cause a delay. > > The proposal to add a connection state test in srp_send_tsk_mgmt() makes > sense to me. That would help to reduce the time spent in the SCSI error > handler after an orderly target shutdown (when it sent a DREQ).
Did you update the patch? I think I'm on-board with the idea. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
