On 20/12/2012 15:19, Bart Van Assche wrote:
On 12/20/12 13:38, Or Gerlitz wrote:
I think few days ago you had a patch on your tree named "Save and
restore host_scribble during error handling", is it possible we need
this here for happy removal of the scsi host?

No. Host removal works fine even without that patch.

not on my setup, how do you suggest to proceed here?

Or.

That's because srp_abort() has been modified such that it finishes a request whether or not sending a task management function to the target succeeded. As you can see in scsi_eh_abort_cmnds() if the eh_abort_handler callback function returns SUCCESS then scsi_eh_test_devices() will be passed an empty work_q list. Hence the SCSI error handler function scsi_eh_prep_cmnd() does not get invoked and hence does not have a chance of overwriting the host_scribble field.


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to