On 12/20/12 16:10, David Dillow wrote:
On Thu, 2012-12-20 at 09:13 +0100, Bart Van Assche wrote:
On 12/19/12 19:04, David Dillow wrote:
On Wed, 2012-12-19 at 15:21 +0100, Bart Van Assche wrote:
The connection state must be initialized before srp_connect_target()
is invoked. Drop the assignment in srp_add_target() since it occurs
after srp_connect_target() and since scsi_host_alloc()
zero-initializes the Scsi_Host structure anyway.
The commit message is still wrong. The issue is that
srp_connect_target() has marked us as active, and this patch removes an
assignment that reverses that.
This shouldn't go upstream without the fixed commit message.
Hi Dave,
How about replacing the commit message by the following text:
"Remove an assignment that incorrectly overwrites the connection state
update by srp_connect_target()."
Works for me, ship it!
Thanks ! I will post a fourth version of this patch with the above
commit message to make it easier for Roland.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
