On Mon, 2013-01-07 at 06:34 -0500, Bart Van Assche wrote: > Sorry but this patch looks wrong to me, and that because of the > following reasons: > - A root cause analysis is missing. It has been mentioned in the patch > description that device_del() did hang but an analysis of why that > hang occurred is missing. > - An explanation of why the above patch prevents device_del() to hang is > missing.
Agreed, this needs more explanation -- at least in the email thread, and boiled down in the commit message. > - Invoking srp_disconnect_target() before scsi_remove_host() is wrong > because it prevents the SYNCHRONIZE CACHE command issued by > sd_shutdown() to reach the SRP target. Exactly; we need to understand the hang so that we get a proper shutdown. -- Dave Dillow National Center for Computational Science Oak Ridge National Laboratory (865) 241-6602 office -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
