On Fri, 22 Feb 2013 13:27:10 -0500
Hal Rosenstock <[email protected]> wrote:
> On 2/22/2013 12:13 PM, Ira Weiny wrote:
[snip]
> > +.BI "char * umad_class_str(uint8_t mgmt_class)"
> > +.BI "char * umad_method_str(uint8_t mgmt_class, uint8_t method)"
> > +.BI "char * umad_mad_status_str(be16_t status, char * buf, size_t len)"
> > +.BI "char * umad_attribute_str(uint8_t mgmt_class, be16_t attr_id)"
> > +
> > +.SH "DESCRIPTION"
> > +
> > +.B "char * umad_class_str(uint8_t mgmt_class)"
> > +Return string value of management class enum
> > +
> > +.B "char * umad_method_str(uint8_t mgmt_class, uint8_t method)"
> > +Return string value of method enum
>
> Should this now be:
> Return string value of method for mgmt_class specified
Yea.
[snip]
> > + return ("ReportResp");
> > + case UMAD_METHOD_TRAP_REPRESS:
> > + return ("TrapRepress");
> > + case UMAD_METHOD_RESP:
> > + return ("Resp");
>
> There's no RESP method, right ? So shouldn't UMAD_METHOD_RESP case be
> removed ?
Good point. But then shouldn't that enum value then be defined as
UMAD_METHOD_RESP_MASK?
Ira
>
> -- Hal
>
> > + default:
> > + return ("<unknown");
> > + }
> > +}
> > +
>
> <snip...>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ira Weiny
Member of Technical Staff
Lawrence Livermore National Lab
925-423-8008
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
