> -----Original Message----- > From: [email protected] [mailto:linux-rdma- > [email protected]] On Behalf Of Jason Gunthorpe > Sent: Wednesday, March 20, 2013 12:02 PM > To: brendan doyle > Cc: Weiny, Ira; Boris Chiu; [email protected]; [email protected]; > Pramod Gunjikar > Subject: Re: [Fwd: Re: [PATCH] libibmad: Fixes for failures when not all ports > of HCA are connected] > > On Wed, Mar 20, 2013 at 06:35:02PM +0000, brendan doyle wrote: > > > As far as I can see the library is not documented at all, I can't find > > any man pages. So setting errno is not breaking the interface, and I > > would argue that if it adds value, which it does in this case, then > > what is the objection. Additionally I think if the approach is that > > errno is not set unless documented in a man page, then we should have > > some consistency, a quick grep of errno in libibmad reveals that errno > > is being set in other parts of the library, in libibumad too, we see > > errno set, but again it is not documented in the umad man pages. > > Ideally we would have consistency amongst the IB libraries - try hard to > return -ERRNO like verbs, and only use errno for cases where an int return is > not possible.
Since these calls return int I thought about this. But I am worried about breaking users who may be explicitly checking for -1. OTOH nothing is documented. Ira > > Jason > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the > body of a message to [email protected] More majordomo info at > http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
