which list_del do you mean? in ipoib_cm_tx_start? On Mon, May 20, 2013 at 11:05 AM, Or Gerlitz <[email protected]> wrote: > On 19/05/2013 12:17, Jack Wang wrote: >> >> we added inject_bug sysfs node to make function run into error case, like >> something below. Yes, you are right, we want to speedup the bug reproduce >> process, and we saw the warning and come to conclusion the neigh->list >> corrupted some where. What's your opinion? > > > Yes, for the synthetic experiment you made, there's a possible point here: > > Under the CM error flow (e.g your injected error), we delete a neighbour, > but we also do it from the flow that flush neighbours (e.g when changing the > device mode from UD to CM, as you did in your script). When this happens > concurrently, these two code pieces call for deleting the neighbour from the > list. So the spinlock might not be enough and we should have do > list_del_init(&neigh->list) instead of list_del, helps? > > Or.
-- Mit freundlichen Grüßen, Best Regards, Jack Wang Linux Kernel Developer Storage ProfitBricks GmbH The IaaS-Company. ProfitBricks GmbH Greifswalder Str. 207 D - 10405 Berlin Tel: +49 30 6098 56991-308 Fax: +49 30 6098 56992-203 Email: [email protected] URL: http://www.profitbricks.com Sitz der Gesellschaft: Berlin. Registergericht: Amtsgericht Charlottenburg, HRB 125506 B. Geschäftsführer: Andreas Gauger, Achim Weiss. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
