On 06/12/13 16:58, Sebastian Riemer wrote:
Wait a minute, so you've changed this commit to also hold that target
lock in the following functions in error case:
srp_unmap_data(),
srp_put_tx_iu()
This is different from:
https://github.com/bvanassche/ib_srp-backport/commit/6ce0e30dbb69973926df84292239f0c20f6a2d6c
srp_unmap_data() calls ib_fmr_pool_unmap() which uses an own spin lock
(pool->pool_lock).
srp_put_tx_iu() acquires the target lock as well (target->lock). That's
spin lock in spin lock. I would say that this dead locks.
I like the other version more.
Not sure how I missed that ... I will drop this version and replace it
with the proper fix.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
