> -----Original Message----- > From: Hal Rosenstock [mailto:[email protected]] > Subject: Re: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing > makefile dependency > > On 6/12/2013 2:25 PM, Weiny, Ira wrote: > > What is the error which this fixed? > > It's an issue when parallel make is used (make -j) where this library might > not > have completed building first.
Ok, I've never hit this, just luck I guess. ;-) > > > I would think that the test_testleaks_LDFLAGS would take care of this? > > I don't think so. Ok, seems reasonable. Thanks, applied, Ira > > -- Hal > > > Ira > > > >> -----Original Message----- > >> From: Hal Rosenstock [mailto:[email protected]] > >> Sent: Wednesday, June 12, 2013 4:04 AM > >> To: Weiny, Ira > >> Cc: linux-rdma ([email protected]); Doron Tsur > >> Subject: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add > >> missing makefile dependency > >> > >> > >> Found-by: Doron Tsur <[email protected]> > >> > >> Signed-off-by: Hal Rosenstock <[email protected]> > >> --- > >> diff --git a/libibnetdisc/Makefile.am b/libibnetdisc/Makefile.am > >> index > >> d05604f..2cfcc33 100644 > >> --- a/libibnetdisc/Makefile.am > >> +++ b/libibnetdisc/Makefile.am > >> @@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband > >> test_testleaks_SOURCES = test/testleaks.c test_testleaks_CFLAGS = > >> -Wall > >> $(DBGFLAGS) test_testleaks_LDFLAGS = -libnetdisc > >> +test_testleaks_DEPENDENCIES = libibnetdisc.la > >> > >> libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \ > >> $(srcdir)/include/infiniband/ibnetdisc_osd.h > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
