I've pulled in this series, with the changes mentioned in a separate email, 
plus updates to the patches below (mostly renames of functions, variables, 
enums, etc.).  The updated patches are available from my ibacm.git tree in the 
preload branch.

Please look over those changes and see if you agree with them.  They should be 
as listed below:

> Patches 1-9 clean up documentation and sample config files.

Removed sample config files from the source tree.

> Patch 10 adds the ability to preload the GID and LID destination caches.

I modified the variable names and enums used for preloading, with other naming 
changes.

route_preload - is now used to indicate if the routing data should be preloaded 
and the format to be used.
route_data_file - stores the file name containing the routing data.  The 
default name is ibacm_route.data

The code to parse the file should be mostly unchanged.

> Patch 11 updates the ACM documentation for this.
> Patch 12 fixes the inet_pton buffer space.
> Patch 13 fixes IPv6 support in acme.

Relocated some common functionality into a static function and used 
sockaddr_storage to store the resulting addresses.

> Patch 14 adds the ability to preload the IPv4 and IPv6 destination caches.

Name changes similar to those done for patch 10.

addr_preload - indicates if the address data should be preloaded and the format 
to use
addr_data_file - stores the file name containing the address data.  The default 
name is ibacm_addr.data.

> Patch 15 adds a performance testing option to acme.

Overall, the changes look good.  I just needed to figure out what to call 
everything and tried to keep things consistent.  My preload branch has been 
compile tested, but I have not yet run it.

I only noticed one gap in the implementation, which I commented on directly in 
the code.  The changes require that the routing data be loaded first before the 
address data.  This is the opposite of what occurs for normal operation, where 
the address is resolved before the route.  It would be nice if the address and 
routing preload data were more independent, but that can be added later, maybe, 
someday.

- Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to