On Fri, 2013-06-28 at 14:55 +0200, Bart Van Assche wrote:
> Enable reconnect_delay, fast_io_fail_tmo and dev_loss_tmo
> functionality for the IB SRP initiator. Add kernel module
> parameters that allow to specify default values for these
> three parameters.
> +static int srp_tmo_set(const char *val, const struct kernel_param *kp)
> +{
> + int tmo, res;
> +
> + if (strncmp(val, "off", 3) != 0) {
Trivial nit: this allows 'offended' to turn off the functionality.
Perhaps use two strcmp() to deal with the possible newline? Of course, I
think everyone else follows this pattern so, as I said trvial nit.
Assuming we accept patch 8,
Acked-by: David Dillow <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
