From: Vladimir Koushnir <[email protected]>

double strdup for p_opt->dump_files_dir is causing memory leak

Approach from Bart Van Assche <[email protected]>

Signed-off-by: Vladimir Koushnir <[email protected]>
Signed-off-by: Hal Rosenstock <[email protected]>
---
Change since v1:
Eliminate cast by doing separate strdup

diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
index 7ab1671..d0835b9 100644
--- a/opensm/osm_subnet.c
+++ b/opensm/osm_subnet.c
@@ -1499,7 +1499,8 @@ void osm_subn_set_default_opt(IN osm_subn_opt_t * p_opt)
        p_opt->dump_files_dir = getenv("OSM_TMP_DIR");
        if (!p_opt->dump_files_dir || !(*p_opt->dump_files_dir))
                p_opt->dump_files_dir = strdup(OSM_DEFAULT_TMP_DIR);
-       p_opt->dump_files_dir = strdup(p_opt->dump_files_dir);
+       else
+               p_opt->dump_files_dir = strdup(p_opt->dump_files_dir);
        p_opt->log_file = strdup(OSM_DEFAULT_LOG_FILE);
        p_opt->log_max_size = 0;
        p_opt->partition_config_file = 
strdup(OSM_DEFAULT_PARTITION_CONFIG_FILE);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to