Le 10.10.2013 10:02, Or Gerlitz a écrit :
On 10/10/2013 00:12, Yann Droneaud wrote:
I've suggested reverting temporarily commit 22878db, 436f2ad, 400dbc9
for v3.12 in a previous message [1]. This proposition doesn't sound
acceptable for Or.
So I continue to improve them to be in a better shape for v3.12.
Yan, we are 3-4 days before rc5 and as such renaming/beautifying
things or removing checks for negative values
against unsigned variables et al cleanups are not acceptable. You need
to re-arrange the series such that ONLY the fixes
to the user/kernel API are targeted to 3.12 and appear as the first
2-3 patches, the rest will go to 3.13 subject to review.
It does not only "beautifying" the code: it actually fix it.
In its current form, the code is not acceptable and should not go in
v3.12.
I've made a review of this code but no patch actually fix all the size
computation issues.
http://marc.info/[email protected]
http://marc.info/[email protected]
Even if I move the "renaming" patches later, the data structure name
must
be updated throughout the code, this will make the patchset still a bit
large
for v3.12-rc5.
I really understand it's too big for v3.12, that's why I've proposed to
revert
the current code for v3.12 and push all of this in v3.13.
Also - does git am removes the "Link: yyy" line you added in your
patches while applying them? if not, please place
below the --- line so we will not carry them in the kernel log.
I've added them on purpose so they are kept in the kernel log.
I'm following a good advice found in comments[1] of
"What's missing from our changelogs" article[2]
[1] http://lwn.net/Articles/560392/
[2] http://lwn.net/Articles/560617/
Regards.
--
Yann Droneaud
OPTEYA
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
