Re: [PATCH for-next 7/9] mlx5: Support arbitrary page size to firmware

Thu, 24 Oct 2013 01:06:59 -0700 

On Thu, Oct 24, 2013 at 12:57:47AM -0700, Roland Dreier wrote:
> On Tue, Oct 22, 2013 at 11:53 PM, Eli Cohen <[email protected]> wrote:
> > This patch also fixes several places that referred to PAGE_SHIFT instead of
> > explicit 12 which is the inherent page shift on Connect-IB.
> 
> Patch looks fine but maybe we should have a follow-up that changes
> this magic constant of 12 to something like MLX5_ADAPTER_PAGE_SHIFT
> (defined to 12 in a header somewhere)?
> 
Yes it makes sense.
I am going to send a few more patches and will include one that fixes
the page shift thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to