Agreed, will do the change and resend the patch Thanks Som ________________________________________ From: Hefty, Sean [[email protected]] Sent: Friday, November 15, 2013 3:58 AM To: Prindeville, Philip; Somnath Kotur Cc: [email protected]; [email protected] Subject: RE: [PATCH] IB/CMA: Fix to handle global/non-linklocal IPv6 address in cma_check_linklocal()
> Do you need to check it twice? > > Is the second test now redundant? I agree, the second if statement can be simplified to only check the scope id. > > + > > + if (!(ipv6_addr_type(&sin6->sin6_addr) & IPV6_ADDR_LINKLOCAL)) > > + return 0; > > if ((ipv6_addr_type(&sin6->sin6_addr) & IPV6_ADDR_LINKLOCAL) && > > !sin6->sin6_scope_id) > > return -EINVAL; -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
