On Thu, Dec 12, 2013 at 03:03:15AM +0000, Upinder Malhi (umalhi) wrote: > Why not? > > We can switch to WARN_ON. The kernel provides this macro - > assert_spin_locked - which does asserts via BUG_ON that > spin_is_locked, which makes me think that using BUG_ON in conjunction > with spin_is_locked is legal. We should use this macro instead of > manually asserting, unless that it is not legal, in which case WARN_ON > will do.
It's better to not halt the kernel. That way you can do some debugging. But the main thing is the scheduling with a spin lock held. The other I don't care about. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
