On 23/01/2014 11:47, Yann Droneaud wrote:
Hi,
Le dimanche 03 novembre 2013 à 10:20 +0200, Or Gerlitz a écrit :
>Fix the below few "make W=1" build warnings we have on the IB core.
>
>drivers/infiniband/core/sysfs.c: In function ‘state_show’:
>drivers/infiniband/core/sysfs.c:107: warning: comparison of unsigned expression
>= 0 is always true
>drivers/infiniband/core/verbs.c: In function ‘ib_modify_qp_is_ok’:
>drivers/infiniband/core/verbs.c:783: warning: comparison of unsigned expression
< 0 is always false
>drivers/infiniband/core/verbs.c:784: warning: comparison of unsigned expression
< 0 is always false
>drivers/infiniband/core/iwcm.c: In function ‘destroy_cm_id’:
>drivers/infiniband/core/iwcm.c:330: warning: variable ‘ret’ set but not used
>
>Signed-off-by: Or Gerlitz<[email protected]>
Reviewed-by: Yann Droneaud<[email protected]>
PS: Perhaps you could split the patch in two parts: one to remove the
unused variable, and another to remove the check on unsigned variables ?
Roland decided not to take the unsigned expression < 0 patches, writing
to me
"I applied the unused variable fix, but the others seem not needed,
because the latest kernel seems to include -Wno-sign-compare."
what's your thinking?
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
