Hi,

Le mercredi 19 février 2014 à 09:55 -0500, Prarit Bhargava a écrit :
> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function ‘_ocrdma_modify_qp’:
> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1299:31: error: ‘old_qps’ may be 
> used uninitialized in this function [-Werror=maybe-uninitialized]
>   status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps);
> 
> ocrdma_mbx_modify_qp() (and subsequent calls) doesn't appear to use old_qps
> so it doesn't need to be passed on.  Removing the variable results in the
> warning going away.
> 

Nice to see this warning removed.

> Signed-off-by: Prarit Bhargava <[email protected]>
> 

You should move the signed of after the Cc's.

> Cc: Roland Dreier <[email protected]>
> Cc: Sean Hefty <[email protected]>
> Cc: Hal Rosenstock <[email protected]>
> Cc: Naresh Gottumukkala <[email protected]>
> Cc: Moni Shoua <[email protected]>
> Or Gerlitz <[email protected]>
^^^
There's a missing Cc: tag

> Cc: Matan Barak <[email protected]>
> Cc: "Gottumukkala, Naresh" <[email protected]>

Regards.

-- 
Yann Droneaud
OPTEYA


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to