On Fri, Mar 14, 2014 at 12:14:58PM -0500, [email protected] wrote:
Hi Carol, see my comments below.
Also, can please share with us if you've been making any testing to
these patches, how you tested and what were the results?
> @@ -471,9 +471,12 @@ static void clean_keys(struct mlx5_ib_de
> ent->size--;
> spin_unlock_irq(&ent->lock);
> err = mlx5_core_destroy_mkey(&dev->mdev, &mr->mmr);
> - if (err)
> - mlx5_ib_warn(dev, "failed destroy mkey\n");
> - else
> + if (err) {
> + if (pci_channel_offline(dev->mdev.pdev))
> + kfree(mr);
Why not just check if -EIO returned.
> + else
> + mlx5_ib_warn(dev, "failed destroy mkey\n");
> + } else
> kfree(mr);
> }
> }
> Index: b/drivers/infiniband/hw/mlx5/qp.c
> ===================================================================
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -2564,7 +2564,11 @@ int mlx5_ib_dealloc_xrcd(struct ib_xrcd
>
> err = mlx5_core_xrcd_dealloc(&dev->mdev, xrcdn);
> if (err) {
> - mlx5_ib_warn(dev, "failed to dealloc xrcdn 0x%x\n", xrcdn);
> + if (pci_channel_offline(dev->mdev.pdev))
> + kfree(xrcd);
> + else
> + mlx5_ib_warn(dev, "failed to dealloc xrcdn 0x%x\n",
> + xrcdn);
You chose to give special treatment to this command, why is that?
> return err;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
