> > + uresp.status_page_size = PAGE_SIZE;
> > +
> > + spin_lock(&context->mmap_lock);
> > + uresp.status_page_key = context->key;
> > + context->key += PAGE_SIZE;
> > + spin_unlock(&context->mmap_lock);
> > +
>
> Is it really necessary to spinlock here since context is local to the
> function ?
>
You're correct.
>
> [...]
>
> > diff --git a/drivers/infiniband/hw/cxgb4/user.h
> > b/drivers/infiniband/hw/cxgb4/user.h
> > index 32b754c..11ccd27 100644
> > --- a/drivers/infiniband/hw/cxgb4/user.h
> > +++ b/drivers/infiniband/hw/cxgb4/user.h
> > @@ -70,4 +70,9 @@ struct c4iw_create_qp_resp {
> > __u32 qid_mask;
> > __u32 flags;
> > };
> > +
> > +struct c4iw_alloc_ucontext_resp {
> > + __u64 status_page_key;
> > + __u32 status_page_size;
> > +};
>
> If this is going to be part of the ABI, mind add an explicit padding to
> align the structure on 64bits.
>
Sounds good. Can you provide patches for these?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
