On Wed, May 07, 2014 at 02:39:26PM +0000, Weiny, Ira wrote: > > On Mon, May 05, 2014 at 09:44:49PM -0400, [email protected] wrote: > > > > > +struct ib_user_mad_reg_req2 { > > > + __u32 id; > > > + __u32 qpn; > > > + __u8 mgmt_class; > > > + __u8 mgmt_class_version; > > > + __u16 res; > > > + __u32 flags; > > > + __u64 method_mask[2]; > > > + __u8 oui[3]; /* network order */ > > > + __u8 rmpp_version; > > > +}; > > > > Please make the padding on 64 bit explicit so we don't have weird problems > > mixing 32 and 64 bit code. > > Just to be clear you mean to add a __u32 reserved field to the end of this > struct?
I think that is enough, yes. Yann has been using pahole to investigate these issues. > > Similar comment as for userspace using a host order uint for the oui. > > Ok would you prefer changing this to __u32 and specifying in host order? > Then adjust the padding, like this: > > __u32 oui; > _u8 rmpp_version; > _u8 res[3]; > > To complete the changes? s/res/reserved/ Sure, that seems simpler for all involved. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
