On Fri, 30 May 2014 15:43:39 -0700 Roland Dreier <[email protected]> wrote:
> Looks like this is actually a bug... assuming you guys agree the patch > is correct, I'll add the following: > > commit 165cb465f73c (HEAD, mlx4) > Author: Roland Dreier <[email protected]> > Date: Fri May 30 15:38:58 2014 > > mlx4_core: Move handling of MLX4_QP_ST_MLX to proper switch > statement > > The handling of MLX4_QP_ST_MLX in verify_qp_parameters() was > accidentally put inside the inner switch statement (that handles > which transition of RC/UC/XRC QPs is happening). Fix this by moving > the case to the outer switch statement. > > The compiler pointed this out with: > > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In > function 'verify_qp_parameters': > >> drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:2875:3: > warning: case value '7' not in enumerated type 'enum qp_transition' > [-Wswitch] > case MLX4_QP_ST_MLX: > > Reported-by: kbuild test robot <[email protected]> > Fixes: 99ec41d0a48c ("mlx4: Add infrastructure for selecting VFs > to enable QP0 via MLX proxy QPs") > Signed-off-by: Roland Dreier <[email protected]> Acked-by: Jack Morgenstein <[email protected]> ---- Thanks, Roland! your fix is exactly right! -Jack -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
