On Tue, Aug 12, 2014 at 4:20 PM, Doug Ledford <[email protected]> wrote: > - ret = ib_find_pkey(target->srp_host->srp_dev->dev, > - target->srp_host->port, > - be16_to_cpu(target->path.pkey), > - &attr->pkey_index); > + ret = ib_find_cached_pkey(target->srp_host->srp_dev->dev, > + target->srp_host->port, > + be16_to_cpu(target->path.pkey), > + &attr->pkey_index);
I consider the "cached" operations to be a deprecated interface, and I'd rather remove uses than add new ones. I have a vague dream of fixing everything up so the normal interfaces (ib_find_pkey() etc) don't sleep and are usable everywhere, although that dream will probably never come true. But is there any practical benefit to this change? I don't think saving a few milliseconds at log in time counts -- I would think it's lost in the noise of how long it takes to actually log in, scan for LUNs, etc. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
