On 08/14/14 02:56, [email protected] wrote: > From: Wei Yongjun <[email protected]> > > In case of error, the function create_workqueue() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Signed-off-by: Wei Yongjun <[email protected]> > --- > drivers/infiniband/ulp/srp/ib_srp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c > b/drivers/infiniband/ulp/srp/ib_srp.c > index 7f5ee7f..62d2a18 100644 > --- a/drivers/infiniband/ulp/srp/ib_srp.c > +++ b/drivers/infiniband/ulp/srp/ib_srp.c > @@ -3320,8 +3320,8 @@ static int __init srp_init_module(void) > } > > srp_remove_wq = create_workqueue("srp_remove"); > - if (IS_ERR(srp_remove_wq)) { > - ret = PTR_ERR(srp_remove_wq); > + if (!srp_remove_wq) { > + ret = -ENOMEM; > goto out; > }
Acked-by: Bart Van Assche <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
