Hi Yann,
> -----Original Message-----
> From: Yann Droneaud [mailto:[email protected]]
> Sent: Friday, September 26, 2014 8:54 PM
> To: Devesh Sharma
> Cc: [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH V1] IB/core: memset attr variable to prevent garbage
> data
>
> Hi,
>
> Le vendredi 26 septembre 2014 à 19:30 +0530, Devesh Sharma a écrit :
> > During create-ah from user land, uverbs is sending garbage data in
> > attr.dmac and attr.vlan_id. This patch prevents the same.
> >
>
> Is the last sentence complete ?
Will re-phrase it.
>
> > Fixes: dd5f03beb4f7 ('IB/core: Ethernet L2 attributes in verbs/cm
> > structures')
> >
> > Signed-off-by: Devesh Sharma <[email protected]>
>
> Thanks for the updated patch.
>
> Please put the "Cc:" in the commit message:
>
> Fixes: dd5f03beb4f7 ('IB/core: Ethernet L2 attributes in verbs/cm structures')
> Cc: Matan Barak <[email protected]>
> Cc: Or Gerlitz <[email protected]>
> Signed-off-by: Devesh Sharma <[email protected]>
>
> This way, the list of people involved in handling the issue would be
> recorded in the git history.
> Additionnaly, git send-email gathers the Cc: in the commit message and
> automatically send the email to the people listed.
Sure, I will rollout v2.
I misunderstood it.
>
> > ---
> > drivers/infiniband/core/uverbs_cmd.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/infiniband/core/uverbs_cmd.c
> b/drivers/infiniband/core/uverbs_cmd.c
> > index 0600c50..5ba2a86 100644
> > --- a/drivers/infiniband/core/uverbs_cmd.c
> > +++ b/drivers/infiniband/core/uverbs_cmd.c
> > @@ -2518,6 +2518,8 @@ ssize_t ib_uverbs_create_ah(struct
> ib_uverbs_file *file,
> > attr.grh.sgid_index = cmd.attr.grh.sgid_index;
> > attr.grh.hop_limit = cmd.attr.grh.hop_limit;
> > attr.grh.traffic_class = cmd.attr.grh.traffic_class;
> > + attr.vlan_id = 0;
> > + memset(&attr.dmac, 0, sizeof(attr.dmac));
>
> OK.
>
> > memcpy(attr.grh.dgid.raw, cmd.attr.grh.dgid, 16);
> >
> > ah = ib_create_ah(pd, &attr);
>
> Regards.
>
> --
> Yann Droneaud
> OPTEYA
>
