On Sun, Nov 02, 2014 at 11:30:05AM +0200, Or Gerlitz wrote:
> @@ -886,7 +887,7 @@ struct ibv_context_ops {
> int (*dealloc_pd)(struct ibv_pd *pd);
> struct ibv_mr * (*reg_mr)(struct ibv_pd *pd, void *addr, size_t
> length,
> int access);
> - struct ibv_mr * (*rereg_mr)(struct ibv_mr *mr,
> + int (*rereg_mr)(struct ibv_mr *mr,
> int flags,
> struct ibv_pd *pd, void *addr,
> size_t length,
What is going on here?
Signatures in the ops structure should not be changed without quite a
bit more explanation. I'd like to see this in a dedicated patch with a
proper discussion about why it is safe...
(I admit, I'm confused how this patch is adding rereg_mr when it
already sort of seems to exist)
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
