On Tue, 2015-01-13 at 16:01 -0500, Doug Ledford wrote: > On Tue, 2015-01-13 at 22:13 +0200, Or Gerlitz wrote: > > On Tue, Jan 13, 2015 at 6:45 PM, Doug Ledford <[email protected]> wrote: > > > On Fri, 2015-01-09 at 10:32 +0200, Or Gerlitz wrote: > > >> On Wed, Jan 7, 2015 at 5:04 PM, Or Gerlitz <[email protected]> wrote: > > >> > From: Erez Shitrit <[email protected]> > > >> > > > >> > Following commit 016d9fb25cd9 "IPoIB: fix MCAST_FLAG_BUSY usage" > > >> > both IPv6 traffic and for the most cases all IPv4 multicast traffic > > >> > aren't working. > > >> > > >> Doug, can you ack the breakage introduced by your commit and the fix? > > > > > > I haven't double checked the breakage, I'll take your word for it > > > > just try ping6 or iperf multicast and see it for yourself, please. > > I have. I have them working now. > > > > > > (at the time I did my work, I had multicast debugging on and I verified > > > the > > > join/leave process, but I had assumed that the process would work the > > > same for optional multicast groups as it does for the IPoIB broadcast > > > group and other default IPoIB groups, so I didn't specifically test > > > additional multicast groups above and beyond the broadcast/etc groups). > > > > > > However, the fix is not workable. In particular, as soon as this patch > > > is added to the kernel, you will start getting messages like this: > > > > > > mlx4_ib0: ipoib_mcast_leave on an in-flight join > > > > > > I don't see it on my systems, is that upstream you're running? what entity > > does > > ,;x4_ib0: prefixed prints and under what settings, is that the IPoIB driver? > > No, that's my internal rhel7 tree, but it's so close to bare upstream > when it comes to IPoIB that there really shouldn't be any difference.
I've tested my patch on a plain upstream kernel and it resolves the problem there too. So, I feel confident that the issue is resolved properly with this patch. Roland, do you need a different submission, or can you take the patch from my last email? -- Doug Ledford <[email protected]> GPG KeyID: 0E572FDD
signature.asc
Description: This is a digitally signed message part
