On Fri, 2015-01-23 at 09:07 +0200, Or Gerlitz wrote: > >> 2. Sync between ipoib_mcast_sendonly_join() to > >> ipoib_mcast_sendonly_join_complete > >> using a IS_ERR_OR_NULL() test > > > This part is no good. You just added a kernel data corrupter or kernel > > oopser depending on the situation. > > Yep, you probably have a point here, but didn't that exist prior to > your 3.19-rc1 series too? in other words, if bug X was there before > and you added bug Y and we fix Y that's fine and by the rules.
No. My patch set was written in response to bug A. That bug actually had multiple sub-bugs that contributed to it. This was one of them. Saying that it is OK because it existed before is to deny the entire purpose of the changes. -- Doug Ledford <[email protected]> GPG KeyID: 0E572FDD
signature.asc
Description: This is a digitally signed message part
