> -----Original Message----- > From: Or Gerlitz [mailto:[email protected]] > Sent: Friday, January 23, 2015 2:02 AM > To: Doug Ledford > Cc: [email protected]; Roland Dreier; Amir Vadai; Eyal Perry; Erez > Shitrit; Estrin, Alex > Subject: Re: [PATCH FIX For-3.19 v5 00/10] Fix ipoib regressions > > On Thu, Jan 22, 2015 at 4:31 PM, Doug Ledford <[email protected]> wrote: > > My 8 patch set taken into 3.19 caused some regressions. This patch > > set resolves those issues. > > Doug, Roland - eight rc1 patches followed ten rc6 fixes - sounds a bit > too much to me. If we (and Linus) like or not, probably the right > thing to do is revert the rc1 patches and come up with a set of > hopefully < 18 patches for 3.20 - using squashes and such, and there's > not much time for that too, BTW. > > Taking into account Doug's listing of the remaining problems in the > original set which are not addressed by the patch Erez suggested, this > isn't an option either. > > Alex, you acked all the series, haven't you noticed the IPv6 and IPv4 > multicast breakage or it worked for you? >
I didn't run elaborate multicast tests on the patch-set so I didn't hit it. Was concentrated on initialization flow. That was a mistake. > Or. > > > Doug Ledford (10): > > IB/ipoib: fix IPOIB_MCAST_RUN flag usage > > IB/ipoib: Add a helper to restart the multicast task > > IB/ipoib: make delayed tasks not hold up everything > > IB/ipoib: Handle -ENETRESET properly in our callback > > IB/ipoib: don't restart our thread on ENETRESET > > IB/ipoib: remove unneeded locks > > IB/ipoib: fix race between mcast_dev_flush and mcast_join > > IB/ipoib: fix ipoib_mcast_restart_task > > IB/ipoib: flush the ipoib_workqueue on unregister > > IB/ipoib: cleanup a couple debug messages > > > > drivers/infiniband/ulp/ipoib/ipoib.h | 1 + > > drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 + > > drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 234 > > ++++++++++++++----------- > > 3 files changed, 131 insertions(+), 106 deletions(-)
